Skip to content

Fix: Accept all 2xx HTTP status codes as success #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanef wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Accept all 2xx HTTP status codes as success #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c2774b
Fix: Accept all 2xx HTTP status codes as success
alanef Sep 2, 2025
b93e2f6
Fix multipart file upload MIME type corruption
alanef Oct 14, 2025
925809e
Fix binary download corruption by setting encoding to null for ZIP files
alanef Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions Freemius.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,11 @@ class Freemius {

};

// For binary downloads (like .zip files), set encoding to null
if (pCanonizedPath.endsWith('.zip')) {
options.encoding = null;
}

let content_type = 'application/json';
let json_encoded_params = empty(pParams) ? '' : JSON.stringify(pParams);

Expand Down Expand Up @@ -414,8 +419,9 @@ class Freemius {
request(options, function (error, response, body) {
//console.log(error);
//console.log(response);
if (!error && response.statusCode == 200) {
responseCallback(response.body);
// Accept any 2xx status code as success (200-299)
if (!error && response.statusCode >= 200 && response.statusCode < 300) {
responseCallback(response.body || '');

} else {
console.log("Error:Stats Code:"+response.statusCode);
Expand Down Expand Up @@ -454,8 +460,9 @@ class Freemius {
data +=
('--' + pBoundary + os.EOL) +
(`Content-Disposition: form-data; name="${name}"; filename="${filename}"` + os.EOL) +
(`Content-Type: ${this.GetMimeContentType(file_path)}` + os.EOL);

(`Content-Type: ${this.GetMimeContentType(file_path)}` + os.EOL) +
os.EOL;

content = fs.readFileSync(file_path);
}

Expand Down