Add soft @return type declarations to interfaces and base classes#44
Open
mpdude wants to merge 1 commit into
Open
Add soft @return type declarations to interfaces and base classes#44mpdude wants to merge 1 commit into
@return type declarations to interfaces and base classes#44mpdude wants to merge 1 commit into
Conversation
mpdude
added a commit
to mpdude/MinkExtension
that referenced
this pull request
Dec 17, 2025
Squash-merge of FriendsOfBehat#44 commit b9b8be4 Author: Matthias Pigulla <mp@webfactory.de> Date: Wed Dec 17 18:44:01 2025 +0100 Add soft `@return` type declarations to interfaces and base classes
mpdude
force-pushed
the
interface-strict-types
branch
from
b9b8be4 to
bf8363d
Compare
stof
reviewed
Dec 17, 2025
mpdude
force-pushed
the
interface-strict-types
branch
from
7813724 to
e8ae83a
Compare
aik099
approved these changes
Dec 18, 2025
mpdude
force-pushed
the
interface-strict-types
branch
from
e8ae83a to
bdbdc2c
Compare
Author
|
Rebased to resolve merge conflicts |
# Conflicts: # UPGRADING.md
mpdude
force-pushed
the
interface-strict-types
branch
from
bdbdc2c to
c92dbb0
Compare
Author
|
@pamil at least as of #51, This PR here was intended to prepare those changes in a non-breaking way and to advise downstream users of upcoming changes. If you are still interested in this, please adivse – we'd probably at least need a 2.x branch where we can merge this, and then merge-up into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Announcing the return types this way may allow us to use language-level type declarations in the next major version.