Bump minimum requirements for a 2.8 release#47
Conversation
8f7af0a to
e844482
Compare
e844482 to
e05862e
Compare
This raises minimum requirements to PHP 8.1, Symfony components with any kind of maintenance (if security only).
e05862e to
b78c73b
Compare
|
@stof WDYT? |
|
I could also use Flex to make sure also transitive Symfony dependencies match the given version. |
|
using Flex would be better for 2 reasons:
|
| - php-version: '8.1' | ||
| symfony-version: '5.4.*' | ||
| - php-version: '8.1' | ||
| symfony-version: '6.4.*' |
There was a problem hiding this comment.
I would also add an explicit job for Symfony 7.4, as it is also a LTS version.
| - '7.4' | ||
| - '8.0' | ||
| - '8.1' | ||
| - '8.2' |
There was a problem hiding this comment.
I would also keep a job on PHP 8.1 with unmodified dependencies.
| - '8.1' | ||
| - '8.2' | ||
| - '8.3' | ||
| - '8.4' |
There was a problem hiding this comment.
as you are adding new PHP versions, you can add 8.5 as well.
|
Looks like this was partially addressed by #50 - although I agree it would be better to manage the symfony requirements with flex instead of the custom script. It also looks like the project no longer declares its supported |
This raises minimum requirements to PHP 8.1, Symfony components with any kind of maintenance (if security only).
Test matrix covers: