Fixed bugs in filtering and editing fields in relationship#1049
Open
SeptimusLiu wants to merge 1 commit intoFrozenNode:masterfrom
Open
Fixed bugs in filtering and editing fields in relationship#1049SeptimusLiu wants to merge 1 commit intoFrozenNode:masterfrom
SeptimusLiu wants to merge 1 commit intoFrozenNode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is some bugs when I use the type "relationship" in edit_fields and filters in model config file, it will update the id fields instead of the foreign key I've set in
belongsTo('\App\Models\MtrGroup', 'foreign_key', 'local_key'). Details for issue can be seen on #1048This commit fixed bugs above for me, and I hope it can be merged and prevent similiar problems.