Abstract position tests from sp-show--pair-function.#355
Open
tasshin wants to merge 1 commit intoFuco1:masterfrom
Open
Abstract position tests from sp-show--pair-function.#355tasshin wants to merge 1 commit intoFuco1:masterfrom
tasshin wants to merge 1 commit intoFuco1:masterfrom
Conversation
Author
|
Fuco, if you think this is a good idea, I'd just check that you're ok with the let* function setting ok to match. I'm not exactly sure what that is doing, and I think it's still called, so I kept it in there. Come to think of it, you might only need let now, instead of let*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some abstractions suggested in issue #349. This should make the creation of helper functions easier, as well as make sp-show--pair-function a little cleaner.