set :end correctly when no next sexp in sp-get-hybrid-sexp#975
Open
edam wants to merge 3 commits intoFuco1:masterfrom
Open
set :end correctly when no next sexp in sp-get-hybrid-sexp#975edam wants to merge 3 commits intoFuco1:masterfrom
edam wants to merge 3 commits intoFuco1:masterfrom
Conversation
Contributor
Author
|
Fixes #974. |
Contributor
Author
|
Tests now pass as well as they do without this patch! (i.e., diff of ert-runner is identical, with and without these changes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to work for me.
The logic is that when
sp-forward-sexp(insp--get-hybrid-sexp-end) returns a next sexp whose:begis before point, it must be because there are no more and it returned the parent sexp. And so, when:beg< point, either the end of the line or the end of the parent sexp, whichever is sooner.