Add README for Qrisp to MLIR conversion#56
Merged
Conversation
rainij
requested changes
May 27, 2026
julfarn
requested changes
May 27, 2026
Collaborator
julfarn
left a comment
julfarn
left a comment
There was a problem hiding this comment.
I suggest to not use stableHLO manually or renaming, since what we will get from the soon-to-be-released version of qrisp will be different (they do some cleanup).
In my opinion, this is a good workflow:
- Fix a recent commit in the branch
linalg_loweringused in this PR: eclipse-qrisp/Qrisp#528 - pip install qrisp from github at that commit tag (hope this can be done)
- export using
make_jaspr(my_kernel_function)().to_mlir(lower_stablehlo=True)
Hopefully when the feature is released in 2 weeks, we can swap out the github installation with a standard installation.
What do you think?
Collaborator
|
A nitpick and a question, then I'm happy with this 👍 |
julfarn
reviewed
May 27, 2026
julfarn
reviewed
May 27, 2026
rainij
requested changes
May 27, 2026
Refactoring Co-authored-by: Julian Farnsteiner <143944161+julfarn@users.noreply.github.com> Signed-off-by: Riccardo Romanello <riccardo.romanello@gmail.com>
julfarn
approved these changes
May 28, 2026
rainij
requested changes
May 29, 2026
Contributor
rainij
left a comment
rainij
left a comment
There was a problem hiding this comment.
Looks almost good, just one small thing.
rainij
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #48
This is a new commit on a new branch because the other one was including commits from another issue/branch as well.