Fix cobblestone duping with hopper below#1
Open
aria1th wants to merge 5 commits intoFulmineo64:masterfrom
Open
Fix cobblestone duping with hopper below#1aria1th wants to merge 5 commits intoFulmineo64:masterfrom
aria1th wants to merge 5 commits intoFulmineo64:masterfrom
Conversation
Owner
|
Hi aria1th. Thank you for your contribution. I see that you use the Fabric API method to move from inventories, does it add some new behavior or makes the Cobble Gen work with modded containers? Please, let me know! Kind regards, |
Author
|
I'm unsure if its fixed now - since setStack method was defined as empty function, hoppers below were able to extract the stack, but failed to decrement item count,which was resulting faster item generation than expected. Also, using the fabric API storage allows interactions with several modded items too, pipes / etc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and add Limit for stack size