Better Dev Experience#100
Open
EddieDover wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the repository to support a better dev build experience. It may be a bit opinionated, and I'm sorry for that1.
TLDR; NPM packages have been updated to modern versions.
npm run buildnow builds to a/distfolder, including compiling all the SCSS files into thecss/mosh.cssfile. All the new styling that was added tomosh.csshas been back-ported into relevant SCSS files so manual changes will need to go into the relevant SCSS files now.@hollowphoton If you hate the entire concept of this, feel free to close it. I just had to patch it up for my own sanity/dev purposes and thought I could give something back.
NPM Packages
Tooling
Styling
SCSS previously heavily used the @import feature, which will be depreciated soon, so this PR modifies all the SCSS to comply with new standards (@use and @forward).
This PR also moves the manually added CSS from the
mosh.cssinto SCSS files, so the build command generated CSS works as intended.Testing Instructions
npm installornpm cinpm run buildNotes
Footnotes
I'm not sure what the build cut/release process is, so this may need some adjusting. ↩
I personally don't use
watchso I wasn't sure what was expected, and this may not work 100% as intended. I keep my repos in a dedicated folder and set up my build scripts to copy things into my foundry data folder. ↩