Update Majority Voting Plots#39
Merged
Merged
Conversation
…ction - Introduced `group_name_mappings` in `MajorityVoteConfig` to allow for custom labels in majority vote results. - Updated `majority_vote_accuracy_by_k` function to accept a `legend_loc` parameter for flexible legend positioning. - Adjusted y-axis limits and tick marks for improved plot clarity. - Modified `run_majority_vote` to utilize group name mappings for filtered results. - Updated YAML configuration to include new group name mappings for better result interpretation.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the majority voting plots by adding group name mappings for cleaner visualization labels and adjusting plot parameters. The changes enable more readable display names for model runs in plots while maintaining the original internal naming conventions.
Key changes:
- Add group name mappings configuration to translate internal run names to user-friendly display names
- Adjust plot y-axis range and legend positioning for better visualization
- Increment k_value by 1 in majority vote processing
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bixbench/run_configuration/v1.5_paper_results.yaml | Adds group name mappings for image comparison and refusal option comparison groups |
| bixbench/postprocessing.py | Implements group name mapping logic and increments k_value |
| bixbench/plotting_utils.py | Updates plot parameters including y-axis range, legend location, and baseline label logic |
| bixbench/models.py | Adds group_name_mappings field to MajorityVoteConfig model |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -160,7 +160,7 @@ async def run_majority_vote( | |||
| return {} | |||
|
|
|||
| # Get configuration values | |||
There was a problem hiding this comment.
The increment of k_value by 1 lacks explanation. This magic number operation should be documented with a comment explaining why the increment is necessary.
Suggested change
| # Get configuration values | |
| # Get configuration values | |
| # Increment k_value by 1 to ensure the range in majority voting includes config.k_value itself. |
ludomitch
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.