Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes multimodal Message serialization so content_is_json_str is not lost in certain dump/roundtrip flows, and provides a safer helper for downstream code to use API-ready content.
Changes:
- Ensure
content_is_json_stris emitted duringmodel_dump(..., context={"include_info": True})when applicable. - Centralize content shaping during serialization via a new
Message.serialized_contenthelper. - Add/extend tests covering multimodal dump expectations and dump→validate roundtrips.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/aviary/message.py |
Adjusts serialization logic and preserves content_is_json_str when include_info is set; adds serialized_content helper. |
tests/test_messages.py |
Adds expectations and roundtrip tests for multimodal serialization and content_is_json_str preservation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamesbraza
approved these changes
Apr 15, 2026
Collaborator
jamesbraza
left a comment
There was a problem hiding this comment.
Nice work! Tests are great
jamesbraza
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
content_is_json_strMessage.content, which can sometimes be a serialized list. As a helper, we provideMessage.serialized_content. Should we cache this? Up for discussion.