Reusing extract_answer_loose in accuracy_reward#7
Merged
jamesbraza merged 3 commits intomainfrom Jun 6, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how the test flag is handled in reward extraction by reusing extract_answer_loose in the accuracy_reward function and updates the README to demonstrate its usage.
- Replaces duplicated logic with a concise ternary expression in rewards.py.
- Updates the README to leverage the new accuracy_reward function for baseline demos.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ether0/rewards.py | Refactors answer extraction to use a ternary expression based on test. |
| README.md | Removes old extraction logic and shows usage of accuracy_reward. |
Comments suppressed due to low confidence (2)
src/ether0/rewards.py:706
- [nitpick] Consider adding parentheses around the ternary expression to improve readability and clarify the execution order.
extract_answer_loose(content) if test else extract_thought_answer_strict(content, reasoning=reasoning)[1]
README.md:191
- [nitpick] Consider adding a brief comment explaining the use of strict=True in zip to clarify intent for future maintainers.
for prob_type, reward in zip(test_ds["problem_type"], rewards, strict=True):
Ryan-Rhys
reviewed
Jun 6, 2025
Ryan-Rhys
approved these changes
Jun 6, 2025
…nce of accuracy_reward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6 forgot to use
testarg, and when adding it just now, I realized:accuracy_rewardshould reuseextract_answer_loosefortestaccuracy_rewarddirectly