Conversation
jamesbraza
reviewed
May 12, 2025
jamesbraza
reviewed
May 12, 2025
| "success_rate": success_rate, | ||
| } | ||
|
|
||
| os.makedirs(f"{output_dir}/{step.step_id}", exist_ok=True) |
There was a problem hiding this comment.
Note stuff like this won't work on Windows, as Windows paths are \\. Best to use os.path.join or pathlib joins
| f"Here is the research question to address:\n" | ||
| f"<query>\n" | ||
| f"{query}\n" | ||
| f"</query>\n" |
There was a problem hiding this comment.
Why the trailing \n in the prompt? I think we should just have "</query>"
Comment on lines
+17
to
+19
| class StepConfig(BaseModel): | ||
| """Configuration for a step in the pipeline.""" | ||
|
|
There was a problem hiding this comment.
What doesn't make sense to me is Step has extensive configuration as many Fields, then we also have a separate StepConfig. It would be good to either:
- Rename
StepConfigto be clearer - Consolidate
StepConfigintoStep
| max_steps: int = Field( | ||
| default=30, description="Maximum number of steps for the agent" | ||
| ) | ||
| timeout: int = Field(default=15 * 60, description="Timeout for the step in seconds") |
There was a problem hiding this comment.
Because callers can have timeouts made by a formula that leads to a float.
In general, something like 2.5 seconds is a valid timeout
| for prompt_text, prompt_args in prompt_pairs[ | ||
| :task_count | ||
| ]: # Limit to requested parallel count | ||
| step_copy = copy.deepcopy(step) |
There was a problem hiding this comment.
Can you add a comment explaining why we deepcopy here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.