Skip to content

remove api keys from metadata build #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mskarlin merged 1 commit into from
May 23, 2025
Merged

remove api keys from metadata build #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/scripts/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
ENVIRONMENT = "PROD"

ENV_VARS = {
# "OPENAI_API_KEY": os.environ["OPENAI_API_KEY"],
# "ANTHROPIC_API_KEY": os.environ["ANTHROPIC_API_KEY"],
"OPENAI_API_KEY": os.environ["OPENAI_API_KEY"],
"ANTHROPIC_API_KEY": os.environ["ANTHROPIC_API_KEY"],
"USE_DOCKER": "false",
"STAGE": ENVIRONMENT,
"ENVIRONMENT": ENVIRONMENT,
Expand Down Expand Up @@ -53,28 +53,24 @@
"model_name": "anthropic/claude-3-7-sonnet-20250219",
"litellm_params": {
"model": "anthropic/claude-3-7-sonnet-20250219",
"api_key": os.environ["ANTHROPIC_API_KEY"],
Copy link
Copy Markdown

@jamesbraza jamesbraza May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can add a ValueError special case somewhere if there is an api_key in litellm_params? Just thinking about catching this moving forward

Copy link
Copy Markdown
Contributor Author

@nadolskit nadolskit May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can totally do that on the server side of the platform 🫡

},
},
{
"model_name": "openai/gpt-4.1-2025-04-14",
"litellm_params": {
"model": "openai/gpt-4.1-2025-04-14",
"api_key": os.environ["OPENAI_API_KEY"],
},
},
{
"model_name": "anthropic/claude-3-5-sonnet-20241022",
"litellm_params": {
"model": "anthropic/claude-3-5-sonnet-20241022",
"api_key": os.environ["ANTHROPIC_API_KEY"],
},
},
{
"model_name": "openai/gpt-4o-2024-11-20",
"litellm_params": {
"model": "openai/gpt-4o-2024-11-20",
"api_key": os.environ["OPENAI_API_KEY"],
},
},
]
Expand Down