Fix subnet EnableDHCP to use *bool for correct omitempty behavior#244
Merged
pedrodeoliveira merged 1 commit intomasterfrom Mar 19, 2026
Merged
Conversation
Change EnableDHCP from bool to *bool in CreateOpts and UpdateOpts so that omitempty can distinguish between "not set" (nil, omitted from JSON, API applies default) and "explicitly set to false".
deferred
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnableDHCPfromboolto*boolinCreateOptsandUpdateOptsso thatomitemptycan distinguish between "not set" (nil, omitted from JSON, API applies default) and "explicitly set to false".--enable-dhcpis explicitly provided.Test plan
go test ./gcore/subnet/v1/subnets/testing/...passesgo build ./gcore/subnet/... && go build ./client/subnets/...compiles