fix: 🎨 Fix dictionary vs wasi env usage inline with rust sdk#30
Merged
fix: 🎨 Fix dictionary vs wasi env usage inline with rust sdk#30
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns FastEdge variable access with the Rust SDK by separating “normal” environment variable reads (WASI process.env) from large-value configuration reads (proxy-wasm dictionary host call), and updates the SDK documentation accordingly.
Changes:
- Update
getEnvto read via WASIprocess.envand addgetDictionaryforproxy_dictionary_get. - Refresh API/docs wording and examples around env vars, dictionary usage, and a few formatting fixes.
- Clarify some docstrings/comments (e.g.,
registerRootContextname parameter, header replace semantics).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/quickstart.md | Fix markdown table formatting and remove stale example count wording. |
| docs/SDK_API.md | Document getDictionary, clarify env var sizing constraints, and improve a few code/doc snippets. |
| assembly/runtime.ts | Improve doc comments for header replacement and registerRootContext name parameter. |
| assembly/fastedge/secrets.ts | Update docs around secret slot selection semantics (but currently introduces a timestamp unit inconsistency). |
| assembly/fastedge/dictionary.ts | Implement WASI-based getEnv and add/export getDictionary using proxy_dictionary_get. |
| CLAUDE.md | Update architecture notes and example list (but currently does not match repo contents). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ruslanti
approved these changes
Apr 16, 2026
|
🎉 This PR is included in version 1.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.