Skip to content

Bugfix/numeric to word#360

Open
SamuelCahyawijaya wants to merge 5 commits intoGEM-benchmark:mainfrom
gentaiscool:bugfix/numeric_to_word
Open

Bugfix/numeric to word#360
SamuelCahyawijaya wants to merge 5 commits intoGEM-benchmark:mainfrom
gentaiscool:bugfix/numeric_to_word

Conversation

@SamuelCahyawijaya
Copy link
Contributor

  • Change isnumeric() to isdigit()
  • Handle unhandled cases in some number transformations

@SamuelCahyawijaya
Copy link
Contributor Author

I think the error is caused by ChangeDateFormat transformation which is not related to our changes whatsoever. How could we go through this problem? Please advice 👍🏻

@AbinayaM02
Copy link
Collaborator

I think the error is caused by ChangeDateFormat transformation which is not related to our changes whatsoever. How could we go through this problem? Please advice 👍🏻

Hi @SamuelCahyawijaya: The error with ChangeDateFormat is fixed a while ago. The current error is because of a mismatch in numeric_to_word transformation only. Please pull the latest code and fix the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants