Skip to content

fix: wellbore nonlinear thermal diffusion documentation example#4041

Open
bd713 wants to merge 6 commits intodevelopfrom
fix/bd713/wellboreDoc
Open

fix: wellbore nonlinear thermal diffusion documentation example#4041
bd713 wants to merge 6 commits intodevelopfrom
fix/bd713/wellboreDoc

Conversation

@bd713
Copy link
Copy Markdown
Contributor

@bd713 bd713 commented Apr 27, 2026

  • Added missing 1/2 factor to internal energy quadratic term, changed dE/dT accordingly (SolidInternalEnergy.hpp)
  • Improved FD solution: accounted for nonuniform grid, BC condition, porosity
  • Refactored doc figure scripts (mimic hydrofrac documentation): shared wellbore example plotting script, query script to extract solution

Previous match:

image

New comparison:

image

@bd713 bd713 self-assigned this Apr 27, 2026
@bd713 bd713 added type: bug Something isn't working type: documentation labels Apr 27, 2026
jhuang2601
jhuang2601 approved these changes May 4, 2026
View reviewed changes
Comment thread src/coreComponents/constitutive/solid/SolidInternalEnergy.hpp

internalEnergy = m_referenceInternalEnergy + volumetricHeatCapacity * ( temperature - m_referenceTemperature );
dInternalEnergy_dTemperature = volumetricHeatCapacity + m_dVolumetricHeatCapacity_dTemperature * ( temperature - m_referenceTemperature );
internalEnergy = m_referenceInternalEnergy + m_referenceVolumetricHeatCapacity * deltaT + 0.5 * m_dVolumetricHeatCapacity_dTemperature * deltaT * deltaT;
Copy link
Copy Markdown
Contributor

@jhuang2601 jhuang2601 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@herve-gross herve-gross Awaiting requested review from herve-gross herve-gross is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bd713 bd713

Labels

type: bug Something isn't working type: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bd713 @jhuang2601