fix: MeshDoctor: only keep faces in generateFracture where the matrix is actually split#250
Merged
fix: MeshDoctor: only keep faces in generateFracture where the matrix is actually split#250
Conversation
jafranc
added
test-geos-integration
jafranc
approved these changes
May 4, 2026
| if fractureInfo.faceCellId != []: # The fracture policy is 'internalSurfaces' | ||
| faceCellId: list[ int ] = [] | ||
| for ns, fId in zip( fractureInfo.faceNodes, fractureInfo.faceCellId ): | ||
| if any( map( isNodeDuplicated.__getitem__, ns ) ): |
Collaborator
There was a problem hiding this comment.
wasn't it exactly np.any( isNodeDuplicated[ns] ) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When building fracture meshes,
__generateFractureMeshdoes not remove from its list ALL faces that are located where the matrix is not actually split.This leads to fault element with no opposite-side cell, which crashes GEOS downstream.
This can happen at fracture intersections (both adjacent cells land on the same side of another fracture's duplication) and fracture tips (no duplication at all on the face), see screenshot below.
Fix
A candidate face is now kept only if the split algorithm assigns different node copies to the face's two adjacent 3D cells for at least one verte. If every vertex resolves to the same copy in both cells, the face is discarded.
Illustration before/after for fracture tips