feat: map SDL scancodes rather than keycodes#23
Merged
Conversation
Contributor
Author
|
Obv, since the SANCO keyboard is not an ISO/ANSI compliant one, this PR would need some changes on CP/M-side keymap, i.e. SLF80037_US.TXT (rename it to .COM, github don't allow me to upload this file). But this is the same one used on the physical machine to have an usable layout. Original SLF file would produce a french(ish) keyboard layout. |
44fff4b to
e13dc5e
Compare
Collaborator
|
I report here what we discussed on the phone.
|
This way, the user's keyboard layout doesn't affect how actual keys are mapped inside the emulator.
CARET key is unused in the current SLF800* map, so it can be useful to function as the additional key in modern ISO keyboards. For example, this key can be commonly found on contemporary French and Italian keyboards.
a33406d to
b1e4e88
Compare
Collaborator
|
I added a commit on top of your in order to support the extra key in ISO keyboards, which is iseful for European layouts. |
giomba
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, the user's keyboard layout doesn't affect how actual keys are mapped inside the emulator.