Parallelized LENS and fix vision error.#120
Merged
SimoneMartino98 merged 4 commits intoGMPavanLab:mainfrom Sep 26, 2025
SimoneMartino98:main
Merged
Parallelized LENS and fix vision error.#120SimoneMartino98 merged 4 commits intoGMPavanLab:mainfrom SimoneMartino98:main
SimoneMartino98 merged 4 commits intoGMPavanLab:mainfrom
SimoneMartino98:main
Conversation
andrewtarzia
requested changes
Sep 26, 2025
Collaborator
andrewtarzia
left a comment
andrewtarzia
left a comment
There was a problem hiding this comment.
Looks good to me - can you ensure there is a test that specifically runs with ncpus>1 and checks the results are unchanged compared to ncpus=1?
Collaborator
Author
All should be ok now |
andrewtarzia
approved these changes
Sep 26, 2025
Collaborator
|
Everything looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone, @matteobecchi @andrewtarzia,
For several reasons, I thought speeding up the LENS performance could be very useful for me and for the group.
I parallelized the neighbor count (in the same way I did for
spatialaverage). Now it is possible to choose the number of cores to use for the calculation.Minor fix:
During development, I discovered that a new version of
ultralyticshad been released, which broke one of the four tests. The issue was related to a plot that, due to the dummy dataset, cannot be printed (and is also completely useless during the test phase), so I simply avoid the plotting.