Skip to content

feat: improve TypeScript diagnosis plugin #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GRAMMAC1 merged 1 commit into from
Jul 7, 2026
Merged

feat: improve TypeScript diagnosis plugin #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/core/src/analysis/aggregate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
import type { CoreAnalysis, CoreAnalysisInput } from '../types/core.js';
import type { PluginResult } from '../types/plugin.js';
import { firstNonEmptyLine } from '../utils/text.js';

function unique(values: string[]): string[] {
return [...new Set(values.filter((value) => value.trim().length > 0))];
}

function firstNonEmptyLine(text: string | undefined): string | undefined {
return text
?.split(/\r?\n/)
.map((line) => line.trim())
.find(Boolean);
}

function pickLeadResult(
pluginResults: PluginResult<unknown, unknown>[],
): PluginResult<unknown, unknown> | undefined {
Expand Down
8 changes: 1 addition & 7 deletions packages/core/src/plugins/generic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import type { CoreAnalysisInput } from '../types/core.js';
import type { Error2FixPlugin } from '../types/plugin.js';

function firstNonEmptyLine(text: string | undefined): string | undefined {
return text
?.split(/\r?\n/)
.map((line) => line.trim())
.find(Boolean);
}
import { firstNonEmptyLine } from '../utils/text.js';

export const genericPlugin: Error2FixPlugin<
{
Expand Down
Loading