Add support for GRTeclyn - #7
Merged
Merged
Conversation
This is conditionally compiled on whether CH_SPACEDIM/AMREX_SPACEDIM is defined.
This is currently required for AMReX's GNU Make build system.
This only tests building the BinaryBH example with TwoPunctures. It may fail not do much initially since the TwoPunctures support has not yet been merged into GRTeclyn. Also rename GRChombo one.
KAClough
approved these changes
Jul 28, 2026
KAClough
left a comment
KAClough
left a comment
Member
There was a problem hiding this comment.
This looks good to me and we have tried it and it works.
I will add the README info to the GRTeclyn documentation at some point soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary modifications to TwoPunctures in order to enable integration with GRTeclyn.
I'll add more detail on the relevant GRTeclyn PR once I have opened that but they should be reviewed together.
I've also added a GitHub Actions workflow which mirrors the existing one for GRChombo. It just builds the BinaryBH example with TwoPunctures.