Skip to content

fix: resolve final 4 bugs before convergence #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GT-610 merged 1 commit into from
Jun 10, 2026
Merged

fix: resolve final 4 bugs before convergence #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pages/download_page/components/task_action_dialogs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ class TaskActionDialogs {
error: e,
stackTrace: stackTrace,
);
failCount += tasks.length;
failCount += tasks.length - successCount - skippedCount;
} finally {
client?.close();
}
Expand Down
1 change: 1 addition & 0 deletions lib/pages/download_page/components/task_details_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ class TaskDetailsDialog {
List<Map<String, dynamic>>? peersResult;
String? peersErrorLocal;
try {
if (!outerContext.mounted) return;
final instanceManager = outerContext
.read<InstanceManager>();
final instance = instanceManager.getInstanceById(
Expand Down
5 changes: 5 additions & 0 deletions lib/services/aria2_rpc_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,11 @@ class Aria2RpcClient with Loggable {
_webSocketSubscription = null;
_webSocket?.close();
_webSocket = null;
for (final completer in _pendingRequests.values) {
if (!completer.isCompleted) {
completer.completeError(ConnectionFailedException());
}
}
_pendingRequests.clear();
} else {
_httpClient?.close();
Expand Down
2 changes: 1 addition & 1 deletion lib/services/builtin_instance_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ class BuiltinInstanceService with Loggable {
'--bt-load-saved-metadata=${settings['btLoadSavedMetadata'] ?? true}',
'--bt-seed-unverified=${settings['keepSeeding'] ?? false}',
'--listen-port=$btListenPort',
'--dht-listen-port=${settings['dhtListenPort'] ?? 26701}',
'--dht-listen-port=${_resolveEffectiveDhtListenPort(settings)}',
'--enable-dht6=${settings['enableDht6'] ?? true}',
'--conf-path=$_aria2ConfPath',
'--save-session=$sessionPath',
Expand Down