Add Ruff linter and formater#39
Merged
Merged
Conversation
keyprocedure
force-pushed
the
add-linter-formatter
branch
from
af23e03 to
21f612f
Compare
Collaborator
Author
|
@eclipsehl, all checks pass, this PR is good to go |
keyprocedure
requested review from
eclipsehl and
nantonzhang
and removed request for
eclipsehl and
nantonzhang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds linting and code formatting setup using Ruff, following Pyflakes, Black, and isort rules.
Consolidates the linter and formatter commands into a script and Makefile target.
Adds a GitHub Actions workflow that enforces lint and formatting rules on every pull request and and on pushes to main.
Renames
.yamlfiles to.yml.Moves
test_models.pyinto atestsdir.Check linting and formatting using:
make lintAutomatically apply fixes using:
make lint-fixFixes #12
Test Plan
Verified existing code functionality was not changed by running multiple model configs and checking eval metrics.