Spring Cleaning#127
Conversation
Guvante
left a comment
Guvante
left a comment
There was a problem hiding this comment.
Made it through 78 files before calling it a night here are the notes for up to that point
Clean up logic and loggers.
Guvante
left a comment
Guvante
left a comment
There was a problem hiding this comment.
Skipped over any files that were only deletes.
225/385...
Guvante
left a comment
Guvante
left a comment
There was a problem hiding this comment.
Just to call it out I didn't review the massive sets of demon changes as I am getting serious review fatigue so if anyone wants to inspect the several thousands of lines of removed code for behavior changes that would be great.
I think I covered most things except some items but am still 327/406...
Going to see if I can convince GitHub to ignore whitespace since a lot of the remaining ones are those.
https://github.blog/news-insights/product-news/ignore-white-space-in-code-review/ |
I was going to say "GitHub was unhappy about the large PR and apparently broke it" but when I went to grab a screenshot I learned what actually happened was the settings tab got moved to the right side away from the list of commits which is where it used to be... |
koolkrafter5
force-pushed
the
spring-cleaning
branch
from
6a9f7ad to
1f14ed1
Compare
…revented because of damage. Ice grunts now cause slowness while earth grunts prevent jumping.
…t doesn't need to search for :
|
|
||
| // getStrVsBlock | ||
| if (func_150893_a(item, block) <= 1 && !(block instanceof BlockLeavesBase)) { | ||
| if (func_150893_a(item, block) <= 1f && !(block instanceof BlockLeavesBase)) { |
There was a problem hiding this comment.
The change from 1.1 to 1 is intended, correct?
| float localHardness = block.getBlockHardness(world, x, y, z); | ||
|
|
||
| if (localHardness - this.getHardnessDifference() > blockHardness | ||
| || BoundPickaxe.checkPermissions(world, x, y, z, block, meta, player) |
There was a problem hiding this comment.
I assume this is anti-griefing since I don't see it before, right?
3 participants
Many automated fixes and simple renaming of params/vars. Also deleted a few entirely unused classes/methods and code that's been commented for over a decade.
Bigger changes:
Demon entities now inherit a lot of copy-pasted logic like used for taming.
Projectiles inherit copy-pasted logic and removed unused ctors. Not the basic ones with just the world param since those get used by MC through reflection.
Bound tools also now check for player's block breaking permission.
Use modern switch syntax and set many fields to final.