Skip to content

Fix crop-stick placement behaviour (For 2.9, Regression Fix) - #231

Merged
Pxx500 merged 17 commits into
masterfrom
placement-fix
Aug 31, 2026
Merged

Fix crop-stick placement behaviour (For 2.9, Regression Fix)#231
Pxx500 merged 17 commits into
masterfrom
placement-fix

Conversation

@C0bra5

@C0bra5 C0bra5 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes some unintended regressions regarding crop stick placement, builder's wand interactions and item voiding when placing double-crop sticks from #160

Resolves #230
Resolves GTNewHorizons/GT-New-Horizons-Modpack#26256
Resolves #249

Previews

Crops sticks can now be placed by looking at any face of a block.

java_766iOJOMJK.mp4

Builders wand interactions work again

Creative behaviour:

  • Only places double crop sticks when sneaking.
  • Only places single crop sticks when not sneaking.
java_xyvqcmIh2H.mp4

Survival behaviour:

  • While sneaking
    • Single crop stick in the inventory while sneaking:
      • BBW won't place anything and won't show a preview when sneaking
      • ExU will show a preview and will place a single crop stick.
        • Unlike for BBW, I cannot prevent the last stick from being placed.
    • Not enough crop sticks to cover the entire area with double crop sticks:
      • Odd amount:
        • BBW will only place double crop sticks
        • ExU will place as many double crop sticks as it can and leave the last as a single stick.
          • Unlike for BBW, I cannot prevent the last stick from being placed.
      • Even amount:
        • Both only place double crop sticks
    • Enough crop sticks to cover the entire area with double crop sticks:
      • Both only place double crop sticks
  • When not sneaking
    • Both only place single sticks

Single:

java_FI8XekiuaF.mp4

Even amount:

java_Omb3mFrQPf.mp4

Odd amount:

java_otMLMWg2L4.mp4

Enough:

java_PqDakkgLEp.mp4

Checklist

@C0bra5 C0bra5 added Bug Fix Fix a bug. Please link it in the PR. Safe for Stable Bugfix with low break chance for patch releases labels Aug 4, 2026
@C0bra5 C0bra5 changed the title Allow crop stick placement on non-top block faces Allow crop stick placement on non-top block faces (Missing Feature Parity, for 2.9) Aug 4, 2026
@C0bra5 C0bra5 changed the title Allow crop stick placement on non-top block faces (Missing Feature Parity, for 2.9) Allow crop stick placement on non-top block faces (For 2.9, Missing feature parity) Aug 4, 2026
@C0bra5
C0bra5 marked this pull request as draft August 12, 2026 20:16
@C0bra5
C0bra5 marked this pull request as ready for review August 13, 2026 01:15
@C0bra5 C0bra5 changed the title Allow crop stick placement on non-top block faces (For 2.9, Missing feature parity) Fix crop-stick placement behaviour (For 2.9, Regression Fix) Aug 13, 2026

@Eldrinn-Elantey Eldrinn-Elantey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Architecture looks right to me: going back to a placeBlockAt override restores the vanilla placement path (side offset, canPlayerEdit, canPlaceBlockAt), and returning false to suppress the vanilla sound and decrement is correct here. I also traced the double-stick consumption through WandWorker.placeBlocks and it does not void items. The pinned 0.13.12-GTNH tag already contains the ICustomMapping API from BetterBuildersWands#25, so the dependency blocker is resolved.

One real defect below (ignored setBlock return value), the rest is polish.

Comment thread src/main/java/com/gtnewhorizon/cropsnh/items/blocks/ItemCropSticks.java Outdated
Comment thread src/main/java/com/gtnewhorizon/cropsnh/utility/ModUtils.java

@Eldrinn-Elantey Eldrinn-Elantey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pxx500
Pxx500 merged commit b60708b into master Aug 31, 2026
1 check passed
@Pxx500
Pxx500 deleted the placement-fix branch August 31, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Fix a bug. Please link it in the PR. Safe for Stable Bugfix with low break chance for patch releases

Projects

None yet

5 participants