Skip to content

added ability to open backpacks enabled by NoHotbarNeeded#105

Merged
Dream-Master merged 8 commits into
GTNewHorizons:masterfrom
RediskusGaming:feature/actionableBackpack
May 24, 2026
Merged

added ability to open backpacks enabled by NoHotbarNeeded#105
Dream-Master merged 8 commits into
GTNewHorizons:masterfrom
RediskusGaming:feature/actionableBackpack

Conversation

@Erixonich

@Erixonich Erixonich commented Dec 24, 2025

Copy link
Copy Markdown

Added support for potential future mod - NoHotbarNeeded.
Code with mod is here: https://github.com/RediskusGaming/NoHotbarNeeded
Allows to open forestry backpacks without moving them to active slot in hotbar.

A lot of changes in this patch because original code always assumed that item would be in player's hand (see calls to player.getCurrentEquippedItem()).

@UltraProdigy

Copy link
Copy Markdown
Member

@Erixonich This isn't building

Comment thread dependencies.gradle Outdated
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta (experimental build) label May 2, 2026
@Dream-Master

Copy link
Copy Markdown
Member

devOnlyNonPublishable('net.xonich.mc:NoHotbarNeeded:0.0.3') need to be changed to devOnlyNonPublishable('net.xonich.mc:NoHotbarNeeded:0.0.3:dev')
@Erixonich

@Luca-Guettinger Luca-Guettinger left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things I noticed. 1 blocker (missing @ Optional annotations), 1 off-by-one, 4 nits.

Comment thread src/main/java/forestry/storage/items/ItemBackpack.java
Comment thread src/main/java/forestry/storage/items/ItemBackpack.java Outdated
Comment thread src/main/java/forestry/core/inventory/ItemLocation.java Outdated
Comment thread src/main/java/forestry/core/gui/GuiHandler.java
Comment thread src/main/java/forestry/core/gui/GuiHandler.java Outdated
Comment thread src/main/java/forestry/storage/items/ItemBackpack.java
@Dream-Master Dream-Master merged commit bbb374c into GTNewHorizons:master May 24, 2026
1 check passed
@UltraProdigy UltraProdigy removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta (experimental build) label May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants