Skip to content

Fix gather problem#135

Merged
Dream-Master merged 1 commit into
masterfrom
fix/gather-logic
Jun 7, 2026
Merged

Fix gather problem#135
Dream-Master merged 1 commit into
masterfrom
fix/gather-logic

Conversation

@AnsonYeung

@AnsonYeung AnsonYeung commented Jun 7, 2026

Copy link
Copy Markdown

Vanilla shift double click rely on object comparison of the underlying inventory, which is dynamically set in ModularSlot. This PR expose a dummy inventory for object comparison to function based on the underlying slot group.

Both clip test feature in the order of:

  1. shift double click existing stack when inv is full
  2. shift double click with stack held on both inventory

Before:

Minecraft.1.7.10.2026-06-07.22-07-22.mp4

After:

Minecraft.1.7.10.2026-06-07.22-04-48.mp4

Fixes GTNewHorizons/GT-New-Horizons-Modpack#25006

@AnsonYeung AnsonYeung added the bug label Jun 7, 2026
@Dream-Master Dream-Master merged commit f381f6b into master Jun 7, 2026
1 check passed
@Dream-Master Dream-Master deleted the fix/gather-logic branch June 7, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shift clicking too fast to move stacks to other inventories can make the itemstack to move in the source inventory if the destination is full

3 participants