Add check for "." being parsed with exponent E#136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in GTNH discord https://discord.com/channels/181078474394566657/1303308397961019472/1513223411009327419
BigDecimal parser crashes when it's given string like "1E9.0" because "." is not a digit. Adds a check inside
numberOfStringso this doesn't happen, works for complex stuff like5+1e5.0+15*1.8, where it fails and zeroes only1e5.0part. Another way would be to add the checks toparseExpressionWholeNumberandparseExpression, in which case i think it would fail the entire string and return 0.Unless i am understanding it wrong, second option would be "faster" because we have less if else statements in the
numberOfStringthat gets called for each number in the expression at the "cost" of failing the entire string.