Skip to content

do not include mod name while searching normally#950

Closed
sawyergt wants to merge 3 commits into
GTNewHorizons:masterfrom
sawyergt:fix-search
Closed

do not include mod name while searching normally#950
sawyergt wants to merge 3 commits into
GTNewHorizons:masterfrom
sawyergt:fix-search

Conversation

@sawyergt

Copy link
Copy Markdown

closes #861

@Dream-Master Dream-Master requested a review from slprime June 13, 2026 21:01
@slprime

slprime commented Jun 14, 2026

Copy link
Copy Markdown
Member

Not all items have the same mod name and string Identifier

image image image image

and more

@sawyergt

Copy link
Copy Markdown
Author

imo searching by identifier is a more niche use case for nei, so maybe i could add another prefix for identifier search, but idk i guess its your call

@slprime

slprime commented Jun 15, 2026

Copy link
Copy Markdown
Member

Can you provide an example of a search that's causing you trouble? Maybe you should just enable a prefix for the id?

@sawyergt

Copy link
Copy Markdown
Author

nothing in particular, it just felt weird that the mod name is included in the identifier when we have the @ (they don't search the same thing, but it matches most of the time). but I guess its mostly a non issue

@slprime slprime closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search always includes mod name

3 participants