Skip to content

Fix cascading worldgen caused by Oreberries#275

Open
Charsy89 wants to merge 2 commits into
GTNewHorizons:masterfrom
Charsy89:oreberry-cwg-fix
Open

Fix cascading worldgen caused by Oreberries#275
Charsy89 wants to merge 2 commits into
GTNewHorizons:masterfrom
Charsy89:oreberry-cwg-fix

Conversation

@Charsy89
Copy link
Copy Markdown

Adds an offset of +8 to the random coordinates for Oreberry generation. Using ArchaicFix to detect cascading worldgen revealed Tinkers' Construct as an issue mod. After applying the offset, there were no reports of CWG from Tinkers' Construct in the log.
It still occurs periodically due to slime islands, but this is inevitable given their size.

I was originally going to do this as a mixin in Hodgepodge, but it ended up being too complex given TC's behavior with regards to generating Oreberry clusters. Specifically, TC determines an appropriate location to spawn the Oreberries after generating random coordinates, meaning I would have had to inject between variable STOREs or LOADs to add 8 to xPos and zPos so that the findAdequateLocation method's return value would still be proper, which isn't such an elegant solution. Because of this, it is also not possible to apply the offset inside of OreberryBushGen, because again, the Y level returned by findAdequateLocation would become obsolete.
After light discussion in GTNH discord, I concluded that patching GTNH Tinkers Construct directly is the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant