Open
Conversation
This removes the $apiKey from the endpoint implementation. Everything is handled by the AuthenticatedEndpoint trait now. Authentication is inherited.
|
instead of breaking all code that uses this api wrapper, with requiring an additional let nodes use the auth as a base class, with the apikey as optional. this way, nothing is broken and the code still looks clean. $api->account('API_KEY')->achievements()->get();
$api->account()->achievements()->auth('API_KEY')->get() // or
$api->auth('API_KEY')->account()->achievements()->get()
//add
$api->account()->achievements()->get('API_KEY');
//just like
$api->guild()->membersOf('API_KEY', 'GUILD_ID');when used in a get, it is temporary for just that call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the $apiKey from the specific endpoint implementation. Everything is handled by the AuthenticatedEndpoint trait now. The API key can be set in a parent endpoint and is inherited.
Examples:
This is something that could be merged for version 4.0.0.