Skip to content

improve error handling#25

Open
DeeNewcum wants to merge 2 commits into
Gadgetoid:mainfrom
DeeNewcum:main
Open

improve error handling#25
DeeNewcum wants to merge 2 commits into
Gadgetoid:mainfrom
DeeNewcum:main

Conversation

@DeeNewcum

Copy link
Copy Markdown
Contributor

This adds two new errors:

  • "Error: ./pi400 must be run as root"
  • "Error: This must be added to /boot/config.txt and the system rebooted: dtoverlay=dwc2"

Without this error-checking, the beginner user gets some strange errors that don't really correspond to what they need to fix to proceed.

@DeeNewcum

Copy link
Copy Markdown
Contributor Author

I'm a little confused what #define NO_OUTPUT is for, or whether the call to prechecks() should be wrapped in it.

@Gadgetoid

Copy link
Copy Markdown
Owner

NO_OUTPUT is a slightly hamfisted way to disable output to the USB gadget, so the code can be tested on a system without it supported or set up.

IIRC you need root either way, for grabbing the local devices but I could be misremembering.

But yes, the dtoverlay=dwc2 check should be wrapped in #IFNDEF NO_OUTPUT

@Gadgetoid

Copy link
Copy Markdown
Owner

Thank you. I'll try to get this tested & merged this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants