Feat: 게시판 도메인 생성 #16
Open
Feat: 게시판 도메인 생성 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Open
4 tasks
Collaborator
|
깔끔하네요! 수고하셨습니다 🤟🤟🤟 |
bokyung95
reviewed
Dec 4, 2022
Collaborator
bokyung95
left a comment
bokyung95
left a comment
There was a problem hiding this comment.
도메인 작성하시느라 고생많으셨습니다!
매핑 관련하여 궁금한 점이 있어서 리뷰 남깁니다.
Comment, Heart, Post 엔티티는 Member와 양방향으로 하지 않아도 문제가 없을까욤?
Contributor
younghoondoodoom
left a comment
younghoondoodoom
left a comment
There was a problem hiding this comment.
깔끔하네요! 고생하셨습니다~
|
|
||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "image_id") |
Contributor
There was a problem hiding this comment.
도메인 이름 때문에 post_image_id는 어떠신가요?
Collaborator
Author
member 쪽 엔티티가 많은 테이블과 연관 관계 맺으면 클래스가 복잡해지는 것 같아서 일단 단방향으로 설정하고 나중에 필요해지면 추가할 생각입니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.