ntsync-android 7ce6435 release notes + fix wineserver startup crash in init_user_sid patch - #37
Merged
Merged
Conversation
CI already builds ntsync-android HEAD (now 7ce6435). Update the pinned commit reference in the release notes and add changelog entries for adaptive spin-before-block (NTSYNC_SPIN_ITERS), the sweep-trigger RSS fix, and the on-device stats validation.
The machine-id patch assigned f only inside if (getenv(WINEPREFIX)); GameNative sets PREFIX instead, so f stayed uninitialized and fread() ran on a garbage FILE pointer - intermittent SIGSEGV at init_user_sid during wineserver start (seen in tombstone as init_user_sid+200 from main), most visible in GameNative pre-install chains that kill and restart wineserver between steps. Accept PREFIX as fallback, and bail out with a zero machine id when neither variable is set or the file cannot be opened (also covers the prefix-set-but-unwritable case, which had the same NULL-deref).
Collaborator
Author
|
Added a second commit: wineserver startup crash fix. Root cause from the tombstone (init_user_sid+200 from main): the android machine-id patch in server/token.c assigned f only when WINEPREFIX was set; GameNative sets PREFIX, so f was uninitialized and fread() ran on a garbage FILE pointer - intermittent SIGSEGV at wineserver start, most visible in pre-install chains (wineserver -k between steps). Not ntsync-related; proton_11.0 does not have this patch at all. Fix: accept PREFIX as fallback, bail out with a zero machine id when neither is set or the file cannot be opened. Patch verified with git apply --check and rendered output review. |
joshuatam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI builds ntsync-android HEAD (now 7ce6435, already pushed to GameNative/ntsync-android). This updates the release-notes commit pin and adds changelog entries for:
Merging into proton_11.0-2 triggers the release build.