Skip to content

Declare AAudioStreamBuilder_setUsage weak so the sink loads on API 26/27 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuatam merged 1 commit into from
Aug 10, 2026
Merged

Declare AAudioStreamBuilder_setUsage weak so the sink loads on API 26/27 #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pulseaudio-module/module-aaudio-sink.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,19 @@
#undef __INTRODUCED_IN
#define __INTRODUCED_IN(api_level)
#include <aaudio/AAudio.h>

/* AAudioStreamBuilder_setUsage was introduced in API 28, but blanking __INTRODUCED_IN
above also strips the availability annotation that would otherwise have made the
reference weak, so it ends up a *strong* undefined symbol. The NDK links this module
with -z now, so the dynamic linker resolves every undefined symbol at dlopen() time --
before any code in this file, including the API level check below, gets a chance to
run. On an API 26/27 device libaaudio.so does not export it, so the module fails to
load outright; because the daemon runs with --fail=false that surfaces as "no audio"
rather than an error. Redeclaring it weak lets the linker leave the address NULL
instead of failing the load, so the guard below can do its job. */
extern __attribute__((weak)) void AAudioStreamBuilder_setUsage(AAudioStreamBuilder *builder,
aaudio_usage_t usage);

#include <android/log.h>

#define LOG_TAG "GN-PulseAudioSink"
Expand Down Expand Up @@ -166,7 +179,7 @@ static int pa_create_aaudio_stream(struct userdata *u) {
}

if (u->low_latency) {
if (android_get_device_api_level() >= 28) {
if (AAudioStreamBuilder_setUsage && android_get_device_api_level() >= 28) {
AAudioStreamBuilder_setUsage(u->builder, AAUDIO_USAGE_GAME);
}
AAudioStreamBuilder_setSharingMode(u->builder, AAUDIO_SHARING_MODE_SHARED);
Expand Down