Improve frailbox logger error handling#22
Open
qingfeng312 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/claim #20
Improves frailbox legacy logger error handling so file-open, write, flush, and shutdown failures are reported clearly and degrade to
stderrinstead of silently dropping logs.Payment address (USDC on Base):
0xe87b4889baeee4ed60a1b2bfc7b3a6a17bce4ad6Changes
stderrwhen a configured log file cannot be opened or later becomes unwritable.Testing
make -C frailbox logger-error-testpassed.python3 build.pyran and produced the committed diagnostic artifacts.frontendandv2-market-streampassed; the remaining modules failed because local prerequisites are unavailable (cargo,go,cmake,luac,ghc, Java runtime) or because of the existing frailboxMAP_HUGETLBportability issue.Checklist