Skip to content

lint: clean up 75 pre-existing golangci-lint v2.12.2 issues - #10

Merged
MikeBengtson merged 2 commits into
mainfrom
fix/lint-cleanup
May 14, 2026
Merged

MikeBengtson merged 2 commits into
mainfrom
fix/lint-cleanup

Conversation

@MikeBengtson

Copy link
Copy Markdown
Collaborator

Summary

CI was failing on main with 75 golangci-lint issues across the codebase. This PR drives the count to 0.

Resolution:

  • gofmt -w on 35 files (auto-formatting drift)
  • golangci-lint run --fix resolved staticcheck QF/S simplifications
  • Manual fixes for: bodyclose (resp.Body.Close), errcheck (`_ = ...`), staticcheck (TrimPrefix, ST1005 punctuation, SA1012 nil context, SA9003 empty branch, SA4017 nolint with reason), gocritic (appendAssign with explicit make+append), unused (nolint with reason for build-tag-gated symbols)

Notable nolint usage (each with explicit reason in code):

Test plan

  • `go build ./...` clean
  • `go test ./...` — 3816 pass in 125 packages
  • `golangci-lint run --timeout=2m` — 0 issues

Once this merges, PR #9 should pass CI on rebase.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

@MikeBengtson
MikeBengtson merged commit 26a49a6 into main May 14, 2026
3 of 6 checks passed
@MikeBengtson
MikeBengtson deleted the fix/lint-cleanup branch May 14, 2026 12:43
@MikeBengtson
MikeBengtson restored the fix/lint-cleanup branch June 10, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant