Skip to content

ci: decision frontmatter + linux errcheck cleanup - #11

Merged
MikeBengtson merged 1 commit into
mainfrom
fix/ci-followups
May 14, 2026
Merged

MikeBengtson merged 1 commit into
mainfrom
fix/ci-followups

Conversation

@MikeBengtson

Copy link
Copy Markdown
Collaborator

Summary

Two CI failures surfaced by PR #9; both pre-existing on main:

  1. cmd/check-decisions --docs-only failed on `asdd-whitepaper.md` and `gemba-remote.md` (missing `decision:` frontmatter). Added `decision: gm-v0sp` and `decision: gm-o9t8` respectively.
  2. make lint failed on ubuntu (Linux-only `egress_linux.go` lines 44 + 102) — `defer conn.CloseLasting()` errcheck violation. Wrapped both in `func() { _ = conn.CloseLasting() }()`.

Test plan

  • `go run ./cmd/check-decisions --docs-only` — OK 32 docs, 0 errors
  • `go build ./...` clean
  • `golangci-lint run --timeout=2m` — 0 issues on macOS (linux-only file change verified by manual diff)

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

…asting

- docs/design/asdd-whitepaper.md: add `decision: gm-v0sp` frontmatter
- docs/design/gemba-remote.md: add `decision: gm-o9t8` frontmatter
  (both flagged by cmd/check-decisions --docs-only)
- internal/adapter/firecracker/egress_linux.go: wrap defer conn.CloseLasting()
  in a func to satisfy errcheck (this file is //go:build linux so the
  violation only surfaces on the ubuntu CI runner).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@MikeBengtson
MikeBengtson merged commit 1b9e50f into main May 14, 2026
@MikeBengtson
MikeBengtson deleted the fix/ci-followups branch May 14, 2026 13:02
@MikeBengtson
MikeBengtson restored the fix/ci-followups branch June 10, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant