fix(components): show aliases as autocomplete options in lineage filter#1113
Open
fhennig wants to merge 2 commits into
Open
fix(components): show aliases as autocomplete options in lineage filter#1113fhennig wants to merge 2 commits into
fhennig wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Previously, aliases were only used to generate prefix wildcard items (e.g. BA.3.2*) when the alias happened to be a prefix of another lineage name in the tree. This meant aliases that are not prefixes of anything (e.g. BA.3.2 when it has no children named BA.3.2.x) were silently omitted. The fix simplifies the logic: aliases are now always shown as direct autocomplete options (both exact and wildcard), deduplicated case-insensitively to avoid showing noise from lowercase variants. This also makes the previous findMissingPrefixMappings function redundant and removes it entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fhennig
force-pushed
the
feat/lineage-filter-show-aliases
branch
from
491ced5 to
0696291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #926
Summary
BA.3.2) and wildcards (e.g.BA.3.2*)ba.3.2,bA.3.2) are not shown as separate optionsfindMissingPrefixMappingsfunction introduced in fix(components): add missing lineage prefixes to autocomplete list #1024, which handled a subset of this problem (aliases that happened to be prefixes of other lineage names). The new approach is simpler and covers all alias cases, making the prefix detection logic redundant.Background
PR #1024 (d1f34bb) added support for alias-based prefix wildcards (e.g.
BA.3.2*whenBA.3.2is an alias ofB.1.1.529.3.2andBA.3.2.1exists in the tree). However, if the alias was not a prefix of any other lineage name, it was silently omitted from the dropdown entirely — which is the case for leaf lineages likeB.1.1.529.3.2with aliasBA.3.2when no children useBA.3.2as their name prefix.