Skip to content

chore(vscode): use workspace TypeScript to fix .ts import extension errors#1196

Merged
fhennig merged 1 commit into
mainfrom
vscode-typescript-workspace-version
May 13, 2026
Merged

chore(vscode): use workspace TypeScript to fix .ts import extension errors#1196
fhennig merged 1 commit into
mainfrom
vscode-typescript-workspace-version

Conversation

@fhennig
Copy link
Copy Markdown
Contributor

@fhennig fhennig commented May 5, 2026

Summary

  • Adds .vscode/settings.json pointing typescript.tsdk at website/node_modules/typescript/lib
  • VS Code was using its bundled TypeScript, which doesn't honour allowImportingTsExtensions (set in the Astro base tsconfig) — causing false-positive ts(5097) errors on every .ts import path

…rrors

Points VS Code at the project's TypeScript (website/node_modules/typescript)
so it respects allowImportingTsExtensions from the Astro tsconfig, silencing
false-positive ts(5097) errors on .ts import paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboards Ready Ready Preview, Comment May 5, 2026 6:59am

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s VS Code workspace configuration to ensure the editor uses the project’s local TypeScript installation (from website/node_modules) instead of VS Code’s bundled TypeScript, preventing false-positive ts(5097) diagnostics for .ts import extensions when working with the Astro-based site.

Changes:

  • Add .vscode/settings.json setting typescript.tsdk to website/node_modules/typescript/lib so VS Code TypeScript language features use the workspace TypeScript version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fhennig fhennig merged commit 17c522b into main May 13, 2026
15 checks passed
@fhennig fhennig deleted the vscode-typescript-workspace-version branch May 13, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants