Skip to content

feat(website): replace plain textarea in VariantEditor with validated AdvancedQueryFilter#1197

Open
fhennig wants to merge 2 commits into
adv-query-allowed-fieldsfrom
collections-adv-query-validated
Open

feat(website): replace plain textarea in VariantEditor with validated AdvancedQueryFilter#1197
fhennig wants to merge 2 commits into
adv-query-allowed-fieldsfrom
collections-adv-query-validated

Conversation

@fhennig
Copy link
Copy Markdown
Contributor

@fhennig fhennig commented May 5, 2026

depends on #1195

Summary

  • Replaces the plain <textarea> in the collection variant editor's advanced query mode with the validated AdvancedQueryFilter component
  • Restricts users to lineage fields only (using the existing lineageFields config, already passed to VariantEditor)
  • No config changes needed — lineageFields doubles as the allowed fields list; when empty, no restriction is applied

Test plan

  • Manually test: open the collection edit UI, enable "Use advanced query instead", type a lineage query (e.g. BA.1*) — should show checkmark
  • Type a query referencing a disallowed field (e.g. host:Human) — should show error with field name and allowed list
  • Type a mutation query (e.g. A123T) — should pass (no metadata columns referenced)
  • Existing VariantEditor browser spec tests pass

🤖 Generated with Claude Code

… AdvancedQueryFilter

The advanced query mode in the collection variant editor now uses the
same validated query input as the baseline filter, restricting users to
lineage fields only.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboards Ready Ready Preview, Comment May 5, 2026 9:17am

Request Review

@fhennig fhennig changed the base branch from main to adv-query-allowed-fields May 5, 2026 09:10
@fhennig fhennig self-assigned this May 5, 2026
@fhennig fhennig requested a review from fengelniederhammer May 5, 2026 09:11
…spec

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant