Skip to content

refactor: Rename excel-to-pdf to xlsx-to-pdf for API consistency#36

Merged
mido-app merged 2 commits intodevelopfrom
devin/1766371693-xlsx-to-pdf-rename
Dec 22, 2025
Merged

refactor: Rename excel-to-pdf to xlsx-to-pdf for API consistency#36
mido-app merged 2 commits intodevelopfrom
devin/1766371693-xlsx-to-pdf-rename

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 22, 2025

refactor: Rename excel-to-pdf to xlsx-to-pdf for API consistency

Summary

This PR renames all excel_to_pdf references to xlsx_to_pdf across the SDK to align with the API endpoint naming convention (/api/v1/tools/xlsx-to-pdf-*). The change affects CLI commands, client methods, MCP tools, and model classes.

Changes:

  • CLI: excel-to-pdf-analyzexlsx-to-pdf-analyze, excel-to-pdf-executexlsx-to-pdf-execute
  • Client: excel_to_pdf_analyze()xlsx_to_pdf_analyze(), excel_to_pdf_execute()xlsx_to_pdf_execute()
  • MCP: Tool names updated accordingly
  • Models: ExcelPlaceholderXlsxPlaceholder, ExcelToPdfAnalyzeResponseXlsxToPdfAnalyzeResponse, ExcelToPdfExecuteResponseXlsxToPdfExecuteResponse

Functional testing performed:

Updates since last revision

  • Added VCR tests for xlsx_to_pdf_analyze and xlsx_to_pdf_execute in test_client_vcr.py
  • Added VCR cassettes using the VCR疎通用 test template (9da28b03-4a9b-459e-9008-4c9079534050)
  • Updated vcr_utils.py to scrub xlsx_template_id in request bodies
  • All 98 tests now pass (up from 64)

Review & Testing Checklist for Human

  • Breaking change awareness: This is a breaking change for any code using the old excel_to_pdf_* names. Verify this is acceptable given the feature was recently added in PR feat: Add Excel to PDF tools (analyze and execute) #34.
  • VCR cassette review: Verify the cassette contents (tests/cassettes/test_xlsx_to_pdf_*.yaml) are appropriate for the public repo. The template ID is scrubbed to TEMPLATE_ID, but the response contains placeholder definitions (company_name, no, date, price) from the 領収書 template.
  • Completeness check: Search the codebase for any remaining excel_to_pdf or ExcelToPdf references that may have been missed.

Notes

  • All 98 tests pass (unit + VCR)
  • Lint (ruff) and type checks (mypy) pass
  • Minor: The XlsxPlaceholder class docstring still says "Excelプレースホルダー情報" - cosmetic inconsistency

Link to Devin run: https://app.devin.ai/sessions/a818389cfc8d464db4dd1b6432831f93
Requested by: yutaka.omido@generative-agents.co.jp

- Rename CLI commands from excel-to-pdf-* to xlsx-to-pdf-*
- Rename Client methods from excel_to_pdf_* to xlsx_to_pdf_*
- Rename MCP tools from excel_to_pdf_* to xlsx_to_pdf_*
- Rename model classes from ExcelToPdf* to XlsxToPdf*
- Update all unit tests to use new names
- Add xlsx_to_pdf tests to test_mcp.py

This change aligns the SDK naming with the API endpoint naming
(/api/v1/tools/xlsx-to-pdf-*) for consistency.

Co-Authored-By: yutaka.omido@generative-agents.co.jp <yutaka.omido@generative-agents.co.jp>
@devin-ai-integration
Copy link
Contributor Author

Original prompt from yutaka.omido@generative-agents.co.jp
https://github.com/GenerativeAgents/middleman-sdk

ここにあるツールの動作確認をしたいです
本番環境のAPIキーを一時的に発行するのでそれを使って動作確認
以下の2ツールはさまざまなインプットパターンを網羅的にテスト(今回追加したのがこの2ツールのため)
- json-to-pptx系
- xlsx-to-pdf系
それ以外は1インプットパターンずつテストする
なお、まずはCLIから呼べるかを試す uvxを使うやつ


テストに使えるファイルはいかに置いてあったりするので必要に応じて使う
https://github.com/GenerativeAgents/middleman/tree/develop/scripts/materials

全て終わったら俺にAPIキーを消すように促してください
また、成果物はすべて保存しておき最後の報告時にどんなinputでテストした結果がどれなのか、が正確にわかるように報告すること

なお、テストパターンもうらのために以下のテンプレートIDも使ってOK
PPTXテンプレート: c7f05afe-81ed-4a52-94c1-5eeea22516da
XLSXテンプレート: 1dda50be-c018-4478-8a7e-12be5cef6d68

APIキー: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ2IjoiMSIsInN1YiI6ImNhYTRkN2I5L2YzMTVkYmFiL2E5NmNhMzdjIn0.X4W5igTMofZj7RNGbnJPwZMdzuYp5KAsiaywliCObM8

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_pdf_execute

Co-Authored-By: yutaka.omido@generative-agents.co.jp <yutaka.omido@generative-agents.co.jp>
@devin-ai-integration devin-ai-integration bot force-pushed the devin/1766371693-xlsx-to-pdf-rename branch from 008a8ac to ae89498 Compare December 22, 2025 03:44
@mido-app mido-app merged commit 8222809 into develop Dec 22, 2025
4 checks passed
@mido-app mido-app deleted the devin/1766371693-xlsx-to-pdf-rename branch December 22, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant