refactor: Rename excel-to-pdf to xlsx-to-pdf for API consistency#36
Merged
refactor: Rename excel-to-pdf to xlsx-to-pdf for API consistency#36
Conversation
- Rename CLI commands from excel-to-pdf-* to xlsx-to-pdf-* - Rename Client methods from excel_to_pdf_* to xlsx_to_pdf_* - Rename MCP tools from excel_to_pdf_* to xlsx_to_pdf_* - Rename model classes from ExcelToPdf* to XlsxToPdf* - Update all unit tests to use new names - Add xlsx_to_pdf tests to test_mcp.py This change aligns the SDK naming with the API endpoint naming (/api/v1/tools/xlsx-to-pdf-*) for consistency. Co-Authored-By: yutaka.omido@generative-agents.co.jp <yutaka.omido@generative-agents.co.jp>
Contributor
Author
Original prompt from yutaka.omido@generative-agents.co.jp |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
mido-app
approved these changes
Dec 22, 2025
…_pdf_execute Co-Authored-By: yutaka.omido@generative-agents.co.jp <yutaka.omido@generative-agents.co.jp>
008a8ac to
ae89498
Compare
mido-app
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: Rename excel-to-pdf to xlsx-to-pdf for API consistency
Summary
This PR renames all
excel_to_pdfreferences toxlsx_to_pdfacross the SDK to align with the API endpoint naming convention (/api/v1/tools/xlsx-to-pdf-*). The change affects CLI commands, client methods, MCP tools, and model classes.Changes:
excel-to-pdf-analyze→xlsx-to-pdf-analyze,excel-to-pdf-execute→xlsx-to-pdf-executeexcel_to_pdf_analyze()→xlsx_to_pdf_analyze(),excel_to_pdf_execute()→xlsx_to_pdf_execute()ExcelPlaceholder→XlsxPlaceholder,ExcelToPdfAnalyzeResponse→XlsxToPdfAnalyzeResponse,ExcelToPdfExecuteResponse→XlsxToPdfExecuteResponseFunctional testing performed:
xlsx-to-pdf-analyzesuccessfully returned 25 placeholders from templatexlsx-to-pdf-executesuccessfully generated PDF: https://middleman-ai.com/s/c8f5fa6f/k7cQV4LVjjUpdates since last revision
xlsx_to_pdf_analyzeandxlsx_to_pdf_executeintest_client_vcr.py9da28b03-4a9b-459e-9008-4c9079534050)vcr_utils.pyto scrubxlsx_template_idin request bodiesReview & Testing Checklist for Human
excel_to_pdf_*names. Verify this is acceptable given the feature was recently added in PR feat: Add Excel to PDF tools (analyze and execute) #34.tests/cassettes/test_xlsx_to_pdf_*.yaml) are appropriate for the public repo. The template ID is scrubbed toTEMPLATE_ID, but the response contains placeholder definitions (company_name, no, date, price) from the 領収書 template.excel_to_pdforExcelToPdfreferences that may have been missed.Notes
ruff) and type checks (mypy) passXlsxPlaceholderclass docstring still says "Excelプレースホルダー情報" - cosmetic inconsistencyLink to Devin run: https://app.devin.ai/sessions/a818389cfc8d464db4dd1b6432831f93
Requested by: yutaka.omido@generative-agents.co.jp