[MISC] Always prefer decomposed solver on CUDA.#2833
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d0d01322d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| warnings.filterwarnings( | ||
| "ignore", | ||
| category=RuntimeWarning, | ||
| message=r"(divide by zero|invalid value) encountered in (divide|scalar multiply)", | ||
| ) |
There was a problem hiding this comment.
This warnings.filterwarnings call is process-global and runs on every import genesis (via genesis/__init__.py), so it suppresses any RuntimeWarning matching these very common NumPy messages across the entire application, not just trimesh mass-properties code. That can hide real divide/invalid numerical issues in unrelated simulation or user code and reduce debuggability. Please scope the filter (for example with a module= constraint or a local catch_warnings block around the trimesh call site) so only the intended trimesh warning is silenced.
Useful? React with 👍 / 👎.
|
🔴 Benchmark Regression Detected ➡️ Report |
1 participant
No description provided.