Skip to content

Include data providers not from AWS and with more generic file structures - #2

Open
javiquinte wants to merge 18 commits into
GeoNet:mainfrom
javiquinte:main
Open

Include data providers not from AWS and with more generic file structures#2
javiquinte wants to merge 18 commits into
GeoNet:mainfrom
javiquinte:main

Conversation

@javiquinte

Copy link
Copy Markdown

We tried to incorporate buckets from Geofon in the configuration (YAML) and modified the code to allow more generic fiel structures. For instance, SDS structures used by SeisComP.
Path and file name are merged into only one entry in the configuration.
Event bucket is optional. Root directory for waveforms can be absent if the structure starts exactly in the root of the bucket.
The method to download only one file expects to receive a file name (literally). From this file name it will infer all the components (NSLC, start, end) and create the full path based on what is declared in the configuration.

@javiquinte
javiquinte requested a review from a team as a code owner December 18, 2025 20:48
@salichon salichon assigned salichon and pasansherath and unassigned salichon Dec 18, 2025
@salichon salichon added the enhancement New feature or request label Dec 18, 2025
@elidana

elidana commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

thanks a lot @javiquinte , this is amazing!! It is great to see that the software @pasansherath wrote can be extended to GFZ miniseed data holdings as well, so we really appreciate your contribution!

Before we can review this, do you mind please squashing all the different commits into one ? Thanks a lot in advance!

@pasansherath

Copy link
Copy Markdown
Collaborator

Hi @javiquinte thanks for your PR and the improvements. I have gone through your changes and tested them. It works fine with client.get_waveforms() with the client as GFZ. However, the client.read() fails due to a file name parsing error as the location codes for the GFZ miniseed files can be empty.

The function that fails is _parse_mseed_filename(filename, mseed_format) and requires some tweaking for this to work. Is this something you could look into? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants