Refactor and add get_waveforms_bulk - #5
Open
calum-chamberlain wants to merge 2 commits into
Open
Conversation
salichon
assigned
salichon,
Thomas-Benson,
elidana,
pasansherath and
staylorofford and unassigned
salichon,
elidana,
pasansherath and
Thomas-Benson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Issue #4 - this refactors
get_waveformsinto two components that individually find the paths to download, and then download them. This enables aget_waveforms_bulkmethod to make use of threading more effectively.Documentation has not been added, nor have tests. This is mostly here to show what I meant by #4, and gauge interest.