Add github actions testing - #7
Open
calum-chamberlain wants to merge 1 commit into
Open
Conversation
Author
|
Note that because this was changed on a fork, the actions are currently being run on that fork |
Author
|
Looks like tests don't run on Windows due to mseedlib issues. Not sure if this is real or just github actions. Other tests were cancelled because the tests are too slow. Might be worth noting that the tests don't perform very explicit checks that the returned result is correct - they could probably be improved. |
Author
|
Also worth noting that mseedlib is no longer maintained but "lives on" as pymseed. Should this project change to using pymseed? |
|
would need some platform input maybe @pasansherath ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be helpful to have tests run by github actions to aid reviewing PRs to make sure tests still pass. This PR attempts to add that testing.