Skip to content

Add OpennNI 2 driver#4

Open
nh2 wants to merge 9 commits into
GerhardR:masterfrom
nh2:openni2
Open

Add OpennNI 2 driver#4
nh2 wants to merge 9 commits into
GerhardR:masterfrom
nh2:openni2

Conversation

@nh2

@nh2 nh2 commented Apr 8, 2014

Copy link
Copy Markdown

I added OpenNI 2 support, which allows using KFusion with the Asus Xtion and other Primesense devices.

I also included a few other fixes and changed the Makefile so that the C++ compiler, include paths etc. can be set from outside the Makefile and don't need to be hardcoded.

My OpenNI error handling is rigorous but verbose. Tell me if you would prefer a macro instead to make calls+checks one-liners.

@nh2

nh2 commented Apr 8, 2014

Copy link
Copy Markdown
Author

I've tested this with my Xtion and it works pretty well.

Comment thread interface.cpp Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the parameter here be 'true' to enable synchronisation ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@GerhardR

Copy link
Copy Markdown
Owner

Hi,

Thank you for the nice contribution. It is very clean, and I am pretty happy to include it.

I only would like to have a different integration into the build system. We try to use the CMake file as the real build system. The make file is just there for my own quick hacking and I would like to just keep it in the short form it is now.

Would you mind updating your pull request with an updated CMakeLists.txt file to build your driver?

cheers,
Gerhard

@nh2

nh2 commented May 17, 2014

Copy link
Copy Markdown
Author

Yes, but it will take a while since I first have to finish some other 3D scanning stuff :)

@nh2 nh2 mentioned this pull request May 20, 2014
@GerhardR

Copy link
Copy Markdown
Owner

No worries, I am also too busy right now. If I get some time, I will pull in your code commits individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants