ci: make public-hygiene-lint green - #6
Merged
Conversation
added 2 commits
August 8, 2026 16:00
The public-hygiene gate flags text in customer-readable files that describes how the software was BUILT rather than what it DOES. Every hit in this repo is rewritten to state the behaviour or the invariant; no allow markers are added, so the gate keeps its teeth.
`cargo build --all-targets` has been failing outright, so no test in this repo
has run at all:
error[E0063]: missing fields `request_id` and `signals` in initializer of
`RoutingRequest<'_>`
error[E0063]: missing field `signals` in initializer of `Candidate<'_>`
`RoutingRequest` gained `request_id` (a per-request correlation id stamped once
at ingress) and both projections gained a `SignalBag`, in the signal-catalog
work that shipped in busbar 1.5.3. This repo's `.busbar-ref` already pins 1.5.3,
so these fixtures were building a shape the engine no longer hands a hook —
against the very core this plugin releases against.
The fixtures now supply both. `request_id` is a fixed constant because nothing
in the headroom policy reads it and a stable value keeps two otherwise-identical
requests comparable. `signals` is the empty bag, which is what the engine really
passes here: it only populates the bag for signals a hook has asked for, and
this policy asks for none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public-hygiene-lint was RED on
mainin this repo. Every hit is fixed by rewriting the text tostate the BEHAVIOUR rather than our internal process. No allow markers were added anywhere in
this change: a blanket allow would turn the gate into decoration.
Hits found on
main, and the decision for each.github/scripts/next-version.sh+.github/workflows/release-selftest.yml[internal-issue-id]cited an internal guard id. REWRITTEN: id dropped.
docker.yml,release.yml,Dockerfile,docker-compose.yml,docker/bundle/Dockerfilex7[commit-hash-citation] cited bare hashes. REWRITTEN: the quoted CHANGE TITLE is kept where it
exists ("Port headroom-hook to busbar's signed dlopen plugin ABI") and the hash is dropped; the
two references to a busbarAI hash are replaced by what that change did.
docker-bundle.yml,docker.ymlx2,Dockerfile[authoring-meta] narrated the authoringtransaction ("not made unilaterally here", "the agent that authored this file"). REWRITTEN to
state the resulting STATUS: which options are still open, and that the push step is only
exercised by a real tagged run.
docker-bundle.yml,release.ymlx4 [machine-path] shipped a developer home directory, in proseAND in a live
sedcommand. REWRITTEN, and this one is a real behaviour fix rather than awording change: this repo's
Cargo.tomlalready declares SIBLING-RELATIVE path dependencies(
../busbarAI/crates/...), so thesedrewrite of an absolute path had become a no-op. Bothsteps are replaced by the assertion the
sedstep's own trailinggrepwas already making,which is the part that protects the job. Both workflows still parse.
Red before green
Same invocation CI uses. Output is ASCII-folded for this description; the runs are verbatim
otherwise.
Before (on
main)After (this branch)